gh-113212: Improve error message & document zero-arg super inside nested functions and generator expressions #113307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WolframAlph
force-pushed
the
zero-arg-super
branch
from
4973555
to
57cd381
Compare
WolframAlph
changed the title
AlexWaygood
reviewed
Dec 20, 2023
WolframAlph
changed the title
WolframAlph
force-pushed
the
zero-arg-super
branch
from
57cd381
to
cba55de
Compare
Eclips4
reviewed
Dec 20, 2023
AlexWaygood
reviewed
Dec 20, 2023
WolframAlph
force-pushed
the
zero-arg-super
branch
3 times, most recently
from
adb9e79
to
9fdccb7
Compare
carljm
requested changes
Dec 21, 2023
Misc/NEWS.d/next/Core and Builtins/2023-12-20-08-54-54.gh-issue-113212.62AUlw.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
WolframAlph
force-pushed
the
zero-arg-super
branch
from
9fdccb7
to
f13a3cc
Compare
WolframAlph
force-pushed
the
zero-arg-super
branch
from
f13a3cc
to
e21b4f9
Compare
carljm
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
This looks good to me! Thanks @WolframAlph for the contribution. @AlexWaygood, any review comments before I merge?
AlexWaygood
reviewed
Dec 22, 2023
AlexWaygood
reviewed
Dec 22, 2023
WolframAlph
force-pushed
the
zero-arg-super
branch
from
e21b4f9
to
944ab83
Compare
AlexWaygood
approved these changes
Dec 22, 2023
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…de nested functions and generator expressions (pythonGH-113307)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super()error message and document zero-argsuper()usage inside nested functions and generator expressions. #113212📚 Documentation preview 📚: https://cpython-previews--113307.org.readthedocs.build/