GH-113350: Changed the python docs 3.12.1 in logging HOWTO #113424
Conversation
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
| @@ -333,7 +333,7 @@ Suppose you configure logging with the following JSON: | |||
| } | |||
|
|
|||
| This configuration does *almost* what we want, except that ``sys.stdout`` would | |||
| show messages of severity ``ERROR`` and above as well as ``INFO`` and | |||
| show messages of severity ``ERROR`` and only events of this level and higher severity will be tracked as well as ``INFO`` and | |||
There was a problem hiding this comment.
| show messages of severity ``ERROR`` and only events of this level and higher severity will be tracked as well as ``INFO`` and | |
| show messages of severity ``ERROR`` and higher, as well as ``INFO`` and |
And please remove the trailing space at the end of the change in the other file.
| @@ -333,7 +333,7 @@ Suppose you configure logging with the following JSON: | |||
| } | |||
|
|
|||
| This configuration does *almost* what we want, except that ``sys.stdout`` would | |||
| show messages of severity ``ERROR`` and above as well as ``INFO`` and | |||
| show messages of severity ``ERROR`` and only events of this level and higher severity will be tracked as well as ``INFO`` and | |||
There was a problem hiding this comment.
Would prefer the wording "only events of this severity and higher will be tracked" here.
| The default level is ``WARNING``, which means that only events of this level | ||
| and above will be tracked, unless the logging package is configured to do | ||
| otherwise. | ||
| The default level is ``WARNING``, which means that only events of this level and higher severity and above will be tracked, |
There was a problem hiding this comment.
Would prefer the wording "only events of this severity and higher will be tracked" here.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
AlexWaygood
added
needs backport to 3.11
|
okay yeah! I will do changes today itself! sorry for replying late my laptop got into some trouble. |
|
Please could you also edit the PR title to be more descriptive? |
|
I have made the requested changes; please review again |
|
@vaishnavi192 Remember to |
|
Closing as a duplicate of #113491. |
|
@hugovk just wanted to confirm the issue is solved now right? I did it correctly? Open source is bit confusing for now😅 |
|
Yes, it's solved now, and the issue is closed: #113350 What happened:
Next time, I recommend making a new branch, and a PR from that branch, and avoid making any changes directly to your Thank you for your contribution! |
|
Okay got it! Thank you @hugovk for being so welcoming to new contributors. It helps a lot!......Looking forward to contribute more in Python.😄 |
Fix #113350 - Basic logging tutorial: Confusing matrix and use of word "above"
This Pull Request changes the documentation of
logging-cookbook.rstandlogging.rstfrom "above" word to required changes.📚 Documentation preview 📚: https://cpython-previews--113424.org.readthedocs.build/