Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
gh-92936: allow double quote in cookie values #113663
Open
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nburns
force-pushed
the
allow-double-quote-in-cookie-values
branch
from
4e125ac
to
1b3b200
Compare
nburns
commented
Jan 3, 2024
| @@ -442,7 +442,7 @@ def OutputString(self, attrs=None): | |||
| ( # Optional group: there may not be a value. | |||
| \s*=\s* # Equal Sign | |||
| (?P<val> # Start of group 'val' | |||
| "(?:[^\\"]|\\.)*" # Any doublequoted string | |||
There was a problem hiding this comment.
webob handles cookies with quotes more robustly: https://github.com/Pylons/webob/blob/main/src/webob/cookies.py#L335
nburns
force-pushed
the
allow-double-quote-in-cookie-values
branch
2 times, most recently
from
78dce80
to
1b78ed1
Compare
nburns
force-pushed
the
allow-double-quote-in-cookie-values
branch
from
1b78ed1
to
3eae48a
Compare
|
@orsenthil sorry for the random mention, but I saw you were active on some other cookie related issues in the past and wondered if you could review this or help me get pointed in the direction to find someone to review this? |
nburns
force-pushed
the
allow-double-quote-in-cookie-values
branch
from
95af939
to
e9b3cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed more extensively in: #92936 it's not uncommon to see cookies with json and therefore double quotes in them. While IMO a well behaved application would base64 or otherwise encode those values, there are numerous services putting double quotes in the cookies, and it would be nice to have support for this directly in python so various http server/client/util libraries don't need to implement their own cookie parsing. Additionally browsers are tolerant of and handle double quotes in cookie values so
SimpleCookieshould also.Before this change
SimpleCookiewill without error drop cookie values that appear after a value with a double quote in them, which can lead to some very confusing and hard to debug issues when implementing http clients and servers.After this change
SimpleCookieallows a double quote character in the values section of the cookie while making no attempt to determine if the value is valid json or anything else (since that's a application/usecase specific concern)Downstream issues:
aio-libs/aiohttp#7993
yt-dlp/yt-dlp#4780