The Wayback Machine - https://web.archive.org/web/20240503024652/https://github.com/python/cpython/issues/113951
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tkinter: widget.tag_unbind(tag, sequence, funcid) unbind all bindings #113951

Closed
serhiy-storchaka opened this issue Jan 11, 2024 · 0 comments
Closed

Tkinter: widget.tag_unbind(tag, sequence, funcid) unbind all bindings #113951

serhiy-storchaka opened this issue Jan 11, 2024 · 0 comments
Assignees
@serhiy-storchaka
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 11, 2024 •
edited by bedevere-app bot

Bug report

This issue is similar to #75666. When funcid is passed to tag_unbind() methods of Text or Canvas, they remove all bindings and delete only funcid Tcl command. According to the docstrings, they only should remove binding specified by funcid.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error topic-tkinter 3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes labels Jan 11, 2024
@serhiy-storchaka serhiy-storchaka self-assigned this Jan 11, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jan 11, 2024
@serhiy-storchaka
pythongh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now onl…
f0d723b 
…y unbinds "funcid"

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
@bedevere-app bedevere-app bot mentioned this issue Jan 11, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Feb 4, 2024
@serhiy-storchaka
gh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now only unbi…
7e42fdd 
…nds "funcid" (GH-113955)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 4, 2024
@serhiy-storchaka @miss-islington
pythongh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now onl…
a5b8a78 
…y unbinds "funcid" (pythonGH-113955)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
(cherry picked from commit 7e42fdd)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 4, 2024
@serhiy-storchaka @miss-islington
pythongh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now onl…
0b9c0d8 
…y unbinds "funcid" (pythonGH-113955)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
(cherry picked from commit 7e42fdd)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Feb 4, 2024
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Feb 4, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now on…
4548ae7 
…ly unbinds "funcid" (GH-113955) (GH-114997)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
(cherry picked from commit 7e42fdd)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Feb 4, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now on…
f18341f 
…ly unbinds "funcid" (GH-113955) (GH-114998)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
(cherry picked from commit 7e42fdd)

Co-authored-by: Serhiy Storchaka <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now onl…
0785fd5 
…y unbinds "funcid" (pythonGH-113955)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@serhiy-storchaka @fsc-eriker
pythongh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now onl…
4db0fe0 
…y unbinds "funcid" (pythonGH-113955)

Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and
Canvas widgets destroyed the current binding for "sequence", leaving
"sequence" unbound, and deleted the "funcid" command.

Now they remove only "funcid" from the binding for "sequence", keeping
other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes topic-tkinter type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka