The Wayback Machine - https://web.archive.org/web/20240110155306/https://github.com/python/cpython/pull/113824
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113658 : Fixed the issue of 'SMTP.send_message() fails to extract 'RCPT TO' if Cc + Bcc are set' #113824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-113658 : Fixed the issue of 'SMTP.send_message() fails to extract 'RCPT TO' if Cc + Bcc are set' #113824

wants to merge 2 commits into from

Conversation

ilhamalrahm
Copy link

@ilhamalrahm ilhamalrahm commented Jan 8, 2024 •
edited

Fixed Issue #113658

gh-113658: Fixed the issue of 'SMTP.send_message() fails to extract 'RCPT TO' if Cc + Bcc are set'. This was caused due to "strict" evaluation of email.utils.getaddresses which returns list containing a single empty 2-tuple [('', '')] when the resulting list of parsed addresses is greater than the number of fieldvalues in the input list. This event occurs when bcc and cc are empty values (as given in the Issue input to reproduce the issue).

Hence, implemented a fix to check and remove if the fieldvalues have empty values. This fixed the issue #113658.

@ilhamalrahm ilhamalrahm requested a review from a team as a code owner January 8, 2024 20:17
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jan 8, 2024 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ilhamalrahm ilhamalrahm changed the title Fixed issue 113658 gh-113658 : Fixed the issue of 'SMTP.send_message() fails to extract 'RCPT TO' if Cc + Bcc are set' Jan 8, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ilhamalrahm