gh-87092: reduce redundancy and repetition in compiler's optimization stage #96713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Add no_empty_basic_blocks assertion and replace one eliminate_empty_basic_blocks with it
…cks part because that's the responsibility of eliminate_empty_basic_blocks
iritkatriel
added
skip news
interpreter-core
markshannon
reviewed
Sep 9, 2022
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
…ks with linenos too.
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
|
@markshannon buildbots all pass with this. Any further comments? |
sweeneyde
reviewed
Sep 12, 2022
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
markshannon
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
eliminate_empty_basic_blocksby an assertion that there are no empty blockseliminate_empty_basic_blockslogicclean_basic_block-->remove_redundant_nopsfor claritynormalize_basic_block-->check_cfgand reduce it to only check (not remove empty blocks).extend_block-->inline_small_exit_blocks. Make it inline blocks with linenos too (as it used to until bde06e1).IS_UNCONDITIONAL_JUMP_OPCODEmacro in a couple of places instead of checking precise opcodes