MAINT Parameters validation for compose._column_transformer.py #26044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultMetais
force-pushed
the
parameter_validation_column_transformer
branch
3 times, most recently
from
46a2958 to
fc9b203
Compare
glemaitre
reviewed
Apr 1, 2023
ThibaultMetais
force-pushed
the
parameter_validation_column_transformer
branch
from
c70b1ca to
8e06f31
Compare
glemaitre
reviewed
Apr 2, 2023
| "dtype_include": "no_validation", # delegate to pandas | ||
| "dtype_exclude": "no_validation", # delegate to pandas | ||
| } | ||
| ) | ||
| class make_column_selector: |
There was a problem hiding this comment.
I did not see it before but make_column_selector is a class so we cannot use validate_params. Since it is not an estimator (it does not implement fit), we cannot currently use the parameter validation framework.
|
@ThibaultMetais I am going to close this PR. Feel free to select any other function that is not yet validated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
References #24862
What does this implement/fix? Explain your changes.
Adds parameters validation for
make_column_transformerandmake_column_selector.