The Wayback Machine - https://web.archive.org/web/20231008123310/https://github.com/arduino/arduino-cli/pull/2359
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creating new sketches from a template directory #2359

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gsingh93
Copy link

@gsingh93 gsingh93 commented Oct 8, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Implements feature request in #2239

What is the current behavior?

Running arduino-cli sketch new MySketch will create a MySketch/MySketch.ino file.

What is the new behavior?

If directories.template is not set, the behavior is the same as before.

If it is set, running arduino-cli sketch new MySketch will copy the directories.template directory to create the MySketch directory.

Does this PR introduce a breaking change, and is titled accordingly?

This isn't a breaking change.

Other Information

Tests/docs haven't been written. Putting this up as a draft to get initial feedback before putting in more effort. One question how to handle setting sketchMainFilePath. Should we rename some file in the template directory to MySketch.ino? Or just pick a .ino from the directory (ideally there's only one) and return that from the RPC call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant