The Wayback Machine - https://web.archive.org/web/20241103094305/https://github.com/symfony/symfony/pull/58370
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] run tests using PHPUnit 11.3 #58370

Open
wants to merge 2 commits into
base: 7.2
Choose a base branch
from
Open

[WIP] run tests using PHPUnit 11.3 #58370

wants to merge 2 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 24, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Sep 24, 2024
@xabbuh
Copy link
Member Author

xabbuh commented Sep 24, 2024

The PR cannot be merged at the moment as it is based on a bunch of other open pull requests that are paving the way to be able to actually run the tests with PHPUnit 11.

@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from 7178ae5 to 76245c5 Compare September 24, 2024 07:31
@alexandre-daubois
Copy link
Contributor

This is super nice news! Did you already take care of everything required to be "PHPUnit 11 compliant" in already opened PRs ?

@xabbuh
Copy link
Member Author

xabbuh commented Sep 24, 2024

@alexandre-daubois The "ensure session storages are opened before destroying them" commit is the only one that is not already part of an open PR. I do not really understand yet why that change is necessary (the flow in AbstractSessionHandler is different as headers_sent() returns a different result).

@nicolas-grekas nicolas-grekas mentioned this pull request Sep 24, 2024
Merged
nicolas-grekas added a commit that referenced this pull request Sep 25, 2024
@nicolas-grekas
bug #58372 Tweak error/exception handler registration (nicolas-grekas)
de1a6ac 
This PR was merged into the 5.4 branch.

Discussion
----------

Tweak error/exception handler registration

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #53812
| License       | MIT

This should allow removing the custom bootstrap file from #58370 /cc `@xabbuh`

The change on FrameworkBundle leads to a tweaked behavior: we don't override the previous error handler in case it's not the Symfony one. This shouldn't change anything in practice since the error handler is already registered by the runtime component.

The rest is closer to bug fixes.

Commits
-------

af9c035 Tweak error/exception handler registration
@nicolas-grekas
Copy link
Member

We need a way to register DebugClassLoader, and maybe a few other things. Basically what we do in SymfonyTestsListenerTrait.

@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from ab2f604 to e56f932 Compare September 25, 2024 16:42
@xabbuh xabbuh changed the title run integration tests using PHPUnit 11 [WIP] run integration tests using PHPUnit 11 Sep 27, 2024
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 5 times, most recently from d72eadc to c89477a Compare October 10, 2024 06:49
@xabbuh xabbuh changed the title [WIP] run integration tests using PHPUnit 11 run integration tests using PHPUnit 11 Oct 10, 2024
@xabbuh xabbuh changed the title run integration tests using PHPUnit 11 [WIP] run integration tests using PHPUnit 11 Oct 10, 2024
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 3 times, most recently from 361401e to 290aa49 Compare October 17, 2024 06:03
@xabbuh xabbuh changed the title [WIP] run tests using PHPUnit 11 [WIP] run tests using PHPUnit 11.3 Oct 17, 2024
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 8 times, most recently from 42fc5d8 to 5011f6e Compare October 24, 2024 07:06
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 8 times, most recently from d331d8f to f744c59 Compare October 28, 2024 10:29
@wouterj wouterj mentioned this pull request Oct 28, 2024
Closed
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from f744c59 to f84c3d0 Compare October 30, 2024 16:55
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from e057a33 to 975d53c Compare October 30, 2024 17:09
@xabbuh xabbuh mentioned this pull request Oct 30, 2024
Open
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from 975d53c to 3ea600f Compare October 30, 2024 17:40
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from 3ea600f to 319fce8 Compare October 31, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

@stof stof stof left review comments

@welcoMattic welcoMattic Awaiting requested review from welcoMattic welcoMattic is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@kbond kbond Awaiting requested review from kbond kbond is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @alexandre-daubois @nicolas-grekas @staabm @stof @carsonbot @wouterj