The Wayback Machine - https://web.archive.org/web/20250629163315/https://github.com/scikit-learn/scikit-learn/pull/31671
Skip to content

ENH add Array API support for d2_pinball_score and d2_absolute_error_score #31671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ENH add Array API support for d2_pinball_score and d2_absolute_error_score #31671

wants to merge 4 commits into from
+38 −31

Conversation

virchan
Copy link
Member

@virchan virchan commented Jun 28, 2025

Reference Issues/PRs

Towards #26024

What does this implement/fix? Explain your changes.

Adds Array API support for d2_pinball_score and d2_absolute_error_score.

Any other comments?

N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 133d82a. Link to the linter CI: here

@virchan virchan changed the title add Array API support to d2_absolute_error_score and `d2_pinball_sc… ENH add Array API support for d2_pinball_score and d2_absolute_error_score Jun 28, 2025
virchan
virchan commented Jun 28, 2025
View reviewed changes
Copy link
Member Author

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add Array API support for the quantile function to handle cases where sample_weight is None. I'll work on that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Array API module:metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@virchan