DOC: Remove FIXME tags from glossary #31677
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
That looks good overall, thanks @ShauryaDusht.
Only the one Fixme doesn't render correctly (see my comment).
There is a draft PR addressing the same issue (#31674), that seems to be more about fixing a ModuleNotFoundError. I'm not sure if this was a double effort or if these two can combine each other. In general, if someone has already opened a PR, we encourage contributors to wait a few weeks before taking over a task.
| Some estimators, such as decision trees, support negative weights. | ||
| FIXME: This feature or its absence may not be tested or documented in | ||
| many estimators. | ||
| .. FIXME: This feature or its absence may not be tested or documented in many estimators. |
There was a problem hiding this comment.
It seems this FIXME still appears and I think adding an additional blank line right before would help.
Suggested change
| .. FIXME: This feature or its absence may not be tested or documented in many estimators. | |
| .. FIXME: This feature or its absence may not be tested or documented in many estimators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #31628
What does this implement/fix? Explain your changes.
This pull request removes four
FIXMEtags from the Glossary page in the documentation. These tags are not intended for end users and should not appear in user-facing content.Where relevant:
FIXMEnotes into comments to retain context for future contributors.This helps keep the glossary clean, professional, and user-friendly.
Any other comments?
Let me know if any additional changes are needed.