Simple serde array format #9
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarow
force-pushed
the
simple-serde-arrays
branch
from
5aae0fe to
328d21f
Compare
kylecarow
commented
May 7, 2025
kylecarow
force-pushed
the
simple-serde-arrays
branch
from
2749c12 to
283c9fe
Compare
kylecarow
commented
May 8, 2025
src/interpolator/two/tests.rs
Outdated
There was a problem hiding this comment.
@calbaker check it out!
There was a problem hiding this comment.
See https://github.com/NREL/ninterp/blob/simple-serde-arrays/src/serde.rs for how i did it (spoiler: serde(untagged) enums)
kylecarow
force-pushed
the
simple-serde-arrays
branch
3 times, most recently
from
602b3ee to
82242a7
Compare
kylecarow
force-pushed
the
simple-serde-arrays
branch
from
82242a7 to
493318c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an alternate, simplified serde format to be the default serialization format, while also accepting the standard ndarray formats (backwards compatible).
This is basically finished, it just requires RReverser/serde-ndim#2 to be merged (and
Cargo.tomlchanged accordingly) before merging.cc @calbaker