Skip to content

Disable upload by default #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Disable upload by default #7887

wants to merge 1 commit into from

Conversation

lirc572
Copy link

@lirc572 lirc572 commented Apr 17, 2025

Resolves #7535.

This PR simply makes Program.Settings.DisableUpload default to true.

If this is not desired, let's discuss about alternative solutions in #7535.

@Xenthys
Copy link

Xenthys commented Apr 17, 2025

An alternative solution is already implemented, by showing a warning on first upload that explains it'll send your screenshot to Imgur and forcing the user to wait 5 seconds before they can accept. They can refuse immediately though, which will disable uploads until manually reinstated by the user in question.

Since most users still use ShareX to share screenshots, disabling uploads by default and forcing them to dive into advanced settings isn't desirable, unless you are ready to provide a dedicated support team to the ShareX project to handle the influx of questions and complaints from old and new users alike.

@lirc572
Copy link
Author

lirc572 commented Apr 17, 2025

An alternative solution is already implemented, by showing a warning on first upload that explains it'll send your screenshot to Imgur and forcing the user to wait 5 seconds before they can accept. They can refuse immediately though, which will disable uploads until manually reinstated by the user in question.

I remember not seeing this warning when I experienced the problem. I'll re-install the latest version to see if it works as intended. If it does, it sure solves half of the problem. I still personally believe it's better to default to not uploading pictures. E.g. if after taking the first screenshot, the user is shown a success screen with a checkbox for auto-uploading to imgur (with warning sign and unchecked by default), that would be more sensible to me, requiring just one more click for users who like auto-upload while preventing others from accidentally enabling the feature.

Since most users still use ShareX to share screenshots, disabling uploads by default and forcing them to dive into advanced settings isn't desirable

I agree that we should not disable auto-upload for existing users enjoying the feature who upgrade to a version that makes auto-upload disabled by default.

@Nerdoholic
Copy link

An alternative solution is already implemented.

Please read #7535 as to why this is not the proper way to deal with this.

Otherwise I 100% agree with you. Changing this is necessary, yet it should be done in a sane way. Only swapping the Default value will bring much frustration to the existing userbase/nooby newcomers that simply want to use it that way.

E.g. improving the FirstLaunch wizard to enable exactly that userbase to have a great experience using the app is very desirable.

Not kicking the old users in the nuts is doable as well, simply implement a migration for the variables of older versions (there's some finetuning to do here of course regarding user action templates, but it's not that complicated).

But currently the project is frightening professional environments with that setting, and that's simply an unnecessarily dumb thing to do.

@2mustange
Copy link

This is great and follows better security practices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Upload By Default
4 participants