CLI --init-model parameter #2680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have failed to compile it on my ARM Mac because of #2503. |
Evgueni-Petrov-aka-espetrov
requested changes
Aug 20, 2024
| @@ -76,6 +76,10 @@ void BindQuantizerPoolLoadParams(NLastGetopt::TOpts* parser, NCatboostOptions::T | |||
| void BindPoolLoadParams(NLastGetopt::TOpts* parser, NCatboostOptions::TPoolLoadParams* loadParamsPtr) { | |||
| BindQuantizerPoolLoadParams(parser, loadParamsPtr); | |||
|
|
|||
| parser->AddLongOption("init-model", "Init model path") | |||
There was a problem hiding this comment.
looks good
could you please add a test to catboost/pytest to check that train + init-model = train + baseline, where baseline = init-model(train data)?
could you please also add a paragraph about init-model somewhere in catboost/doc/en?
There was a problem hiding this comment.
Are you talking about the --baseline-model-snapshot option? Maybe this is enough and I don't need a new option.
There was a problem hiding this comment.
faucct
force-pushed
the
feature/cli-init-model-parameter
branch
from
91f83db to
9e96402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sorry about not doing the following steps right now and will do them tomorrow, but I wanted to show this and gather some feedback in advance.
I am exposing this parameter, so it would be possible to implement checkpoints in (or outside of)
ai.catboost.spark.CatBoostPredictorTrait#fitfor it to be durable to our Spark cluster freeing spot-VMs.Before submitting a pull request, please do the following steps: