Launching ydoc-server together with language-server #13178
+84
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ GUI Checks ResultsSummary
See individual check results for more details. ℹ️ Chromatic Tests SkippedChromatic visual regression tests were skipped for this PR. To run the tests and deploy Storybook, add the Note: We skip tests by default to optimize CI costs. Only run them when your UI changes are ready for review. 👮 Lint GUI ResultsCheck Results
ESLint🎭 Playwright Test ResultsSummary
|
JaroslavTulach
commented
May 27, 2025
lib/java/ydoc-server/src/main/java/org/enso/ydoc/server/YdocServerImpl.java
Show resolved
Hide resolved
|
Snapshot of memory usage of the JavaScript inside of
The Y.doc JavaScript data structures are estimated to fit into 2MB of memory. |
… at the same port.
JaroslavTulach
requested review from
vitvakatu,
AdRiley,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
JaroslavTulach
commented
May 27, 2025
5 tasks
|
hubertp
added
the
CI: Clean build required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
ydoc-serverrunning in theensoprocessydoc-serveragain in theensoexecutableChecklist & TODO
Inception review has happened on May 28, 2025 and based on that following action items (related to this PR) were identified:
ydoc-serverTypeScript codeScala,
Java,
ensoexecutable size - 480MB - e.g. increase of 74MBydoc-server-nodejssource code - doneydoc-server-nodejsdocker image - done - there still isydoc-server-polyglotdocker image, in case we need 1:1 replacement for the docker image--ydoc-port <number>option tolanguage-serverydoc-portvaluecorepack pnpm dev:guito use this GraalVM based Ydoc server: done.AppImage& co. are OK using the embeddedydoc-serverydoc-server