Skip to content

Update Project Session Logs view #13312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Jun 18, 2025

Pull Request Description

Important Notes

None

Screenshots

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 somebody1234 requested a review from Frizi as a code owner June 18, 2025 09:18
@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 18, 2025
@somebody1234 somebody1234 added the x-new-feature Type: new feature request label Jun 18, 2025
Copy link

github-actions bot commented Jun 18, 2025

✨ GUI Checks Results

Summary

  • 🧹 Prettier: ✅ Passed
  • 🧰 GUI Checks: ✅ Passed
  • 📚 Storybook: ✅ Deployed

All checks passed! Your changes look good to go.

See individual check results for more details.

ℹ️ Chromatic Tests Skipped

Chromatic visual regression tests were skipped for this PR.

To run the tests and deploy Storybook, add the CI: Run Chromatic label to this PR.

Note: We skip tests by default to optimize CI costs. Only run them when your UI changes are ready for review.

👮 Lint GUI Results

Check Results

  • 🧠 Typecheck: ✅ Passed
  • 🧹 Lint: ✅ Passed
  • 🧪 Unit Tests: ✅ Passed

🎭 Playwright Test Results

Summary

  • ⏳ Duration: 5m 36s
  • ✅ Passed: 364 tests
  • 🔴 Failed: 0 tests
  • ⚠️ Flaky: 0 tests

📥 Download Detailed Report

All tests passed! Your changes look good.

Copy link

🔄 GUI Checks in Progress

The following checks are being performed:

  • 🧹 Code formatting with Prettier
  • 👮 Linting and type checking
  • 🧪 Unit tests
  • 🎭 Integration tests with Playwright
  • 📚 Storybook deployment

Results will be updated here once completed.

Copy link
Contributor

@indiv0 indiv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR Approved ✅

@PabloBuchu
Copy link
Contributor

  1. Search should be full width
  2. Logs list don't have scrollbar (and cant scroll down) when I have a project with lots of sessions
  3. Can we have a highlighting search results? Also it should work like in browser cmd+f rather than filter. Right now if I type a random string it will clear the logs

Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use Codemirror in Vue, so some day we should check out if it has same capabilities the dashboard needs from Monaco

@@ -17,6 +17,7 @@ function createHttpClient() {
return new HttpClient({
'x-enso-ide-version': $config.VERSION ?? '',
'x-enso-session-id': sessionID,
'x-enso-version': '2025-01-16',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 16th of January? Last release was in May. If it is valid, please add a comment.

@somebody1234
Copy link
Contributor Author

@PabloBuchu ready for re-QA hopefully. replaced filtering with monaco's search functionality

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants