Remove Enso Devtools from built app; show override status even if Devtools is hidden #13330
+40
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
the
CI: No changelog needed
somebody1234
requested review from
Frizi,
farmaazon and
vitvakatu
as code owners
somebody1234
requested review from
kazcw,
AdRiley,
PabloBuchu and
indiv0
as code owners
✨ GUI Checks ResultsSummary
See individual check results for more details. ℹ️ Chromatic Tests SkippedChromatic visual regression tests were skipped for this PR. To run the tests and deploy Storybook, add the Note: We skip tests by default to optimize CI costs. Only run them when your UI changes are ready for review. 👮 Lint GUI ResultsCheck Results
🎭 Playwright Test ResultsSummary
|
🔄 GUI Checks in ProgressThe following checks are being performed:
Results will be updated here once completed. |
farmaazon
approved these changes
Jun 20, 2025
MODULE.bazel.lock
Outdated
There was a problem hiding this comment.
This should not be merged, as no rust code was changed.
Comment on lines
22
to
24
| const EnsoDevtools = reactComponent( | ||
| process.env.NODE_ENV === 'development' ? EnsoDevToolsReact : () => null, | ||
| ) |
There was a problem hiding this comment.
This logic is duplicated in EnsoDevTools.tsx. I would either do it only here (and make lazy import maybe?) or only there.
somebody1234
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.