Create a subshell per target and kernel when using CommsOverSubshells.PerCommTarget
#17634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
approved these changes
Jun 25, 2025
krassowski
changed the title
CommsOverSubshells.PerCommTarget is also per kernelCommsOverSubshells.PerCommTarget
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 26, 2025
… `CommsOverSubshells.PerCommTarget`
krassowski
changed the title
CommsOverSubshells.PerCommTargetCommsOverSubshells.PerCommTarget
krassowski
pushed a commit
that referenced
this pull request
Jun 26, 2025
…rSubshells.PerCommTarget` (#17660) Co-authored-by: Ian Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Using subshells for comms was originally implemented in #17363. The default option for
CommsOverSubshellsisPerCommTargetmeaning use one subshell per comm target, but this should really be one subshell per kernel per comm target as subshells are specific to a kernel.Fixes #17633.
Code changes
The
private static CommHandler._commTargetSubShellsIdis changed fromto
so that two kernels using the same comm-target will use different subshells, not attempt to erroneously reuse the subshell from just one of the kernels.
User-facing changes
No user facing changes apart from fixing a bug.
Backwards-incompatible changes
None.