Skip to content

[4.3.x] Update altair to fix CI #17648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

[4.3.x] Update altair to fix CI #17648

merged 2 commits into from
Jun 23, 2025

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 23, 2025

References

Just checking if CI still passes on the 4.3.x branch.

Code changes

  • Bump the altair dependency used in the UI tests to fix a failing test

User-facing changes

None

Backwards-incompatible changes

None

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.3.x milestone Jun 23, 2025
@jtpio
Copy link
Member Author

jtpio commented Jun 23, 2025

OK so the UI tests also seem to be failing on the 4.3.x with an empty commit.

Maybe there was a fix on the main branch that we should backport here too.

@jtpio
Copy link
Member Author

jtpio commented Jun 23, 2025

Maybe bumping altair will help?

image

f3362c71c595cf76aa27a1a349dec98a80e22fd1.webm

@jtpio jtpio changed the title [4.3.x] Trigger CI [4.3.x] Update altair to fix CI Jun 23, 2025
@jtpio
Copy link
Member Author

jtpio commented Jun 23, 2025

Maybe bumping altair will help?

Looks like it did:

image

@jtpio jtpio marked this pull request as ready for review June 23, 2025 17:01
@jtpio
Copy link
Member Author

jtpio commented Jun 23, 2025

Merging to fix the CI and help with other backport PRs.

@jtpio jtpio merged commit cd8be28 into jupyterlab:4.3.x Jun 23, 2025
85 checks passed
@jtpio jtpio deleted the troubleshoot-ci branch June 23, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant