Skip to content

Fix colors for CodeMirror panels #17666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jun 27, 2025

References

Fixes jupyterlab-contrib/jupyterlab-vim#153

Code changes

Adds style overrides using Jupyter theme variables.

User-facing changes

Advanced Settings Editor → Ctrl + F

Before After
Screenshot from 2025-06-27 15-29-28 Screenshot from 2025-06-27 15-28-50

jupyterlab-vim / search

Before After
Screenshot from 2025-06-27 15-30-13 Screenshot from 2025-06-27 15-30-33

After across themes

Theme After
Light image
Dark Screenshot from 2025-06-27 15-31-35
Dark High Contrast image
Night image

Note: the "(JavaScript regexp)" text uses inline CSS and comes from jupyterlab-vim so there is nothing we can do about its contrast in this repo.

Backwards-incompatible changes

None

@krassowski krassowski added this to the 4.4.x milestone Jun 27, 2025
@krassowski krassowski added the bug label Jun 27, 2025
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit 73cca87 into jupyterlab:main Jun 27, 2025
84 of 86 checks passed
@krassowski krassowski deleted the fix-contrast branch June 27, 2025 16:49
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jun 27, 2025
krassowski added a commit that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status line font color conflict in Jupyterlab Dark Theme
2 participants