Dockerfile: Install less, vim, and nano #17670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
less is necessary for some git cli tools, like git diff. vim and nano can be editors for git commit. Note that git commit defaults to EDITOR=vi, and this vim install doesn't provide a vi binary, so you still need to set $EDITOR to be able to run git commit.
|
Thanks for making a pull request to jupyterlab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Solves #17668.
Code changes
This installs less, vim, and nano through micromamba. I'm guess that this is the preferred method, so we don't have to worry about which package manager the base image is actually using.
git commitseems to assume EDITOR=vi, if it's not set, and the conda-forge vim package doesn't install or link vi. Thus,git commitstill fails to work until you set $EDITOR yourself. Perhaps there's a vi-is-vim package in conda-forge, but I haven't found it. We could also set $EDITOR in the Dockerfile, if we can agree on what it should be.User-facing changes
None
Backwards-incompatible changes
None