Update copyright, Scala Native, Scala, sbt, ubuntu and macOS to current versions #107
Conversation
LeeTibbert
changed the title
|
If you have a chance, could you take a look at the changes of this PR and see if you concur I'd rest easier knowing that a second set of eyes had checked these. Thank you. My central idea was to use, to the greatest extent possible, the versions, actions, and procedures |
There was a problem hiding this comment.
The only thing I see is that most people are using adopt JVM.
Would something like this work for sbt?
steps:
- uses: actions/checkout@v4
- name: Setup Java
uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: ${{ matrix.java }}
cache: 'sbt'
- uses: sbt/setup-sbt@v1
- run: sbt +test
|
Eric, Thank you for looking at this. I'll try again with 'adopt'. That line in mainline was 'adopt'. I think I ran into a problem Later: CI accepted 'adopt', great! One less change to break. |
|
This PR has been lagering for a while, its time has not come. Do the sbt version and scala-native versions still make sense? Your suggestions and/or thoughts? |
|
Sure, the latest bits are appropriate. Maybe ping Wojciech on this one. |
Thank you for the confirmation. I'll try to create some time this week for a proper
I wanted to make the code sensible (a.k.a current) given the elapsed time before |
A user in the Scala Native Discourse channel reported that these versions
were out of date and that Metals was recommending an update
to the latest Scala LTS version: Done.
Also removed some bit rot from CI versions.
I believe/hope that this will merge cleanly on top of pending PRs.
On a quick read, it looks like most of those will not be merged.
The scala-steward changes might mean I have to re-base after
them.
I will need to submit another PR once SN 0.5.8 had been released and aged
for a fortnight.