Pass mouse info to {on,pre}MouseXXX callbacks #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can pass extra arguments to bufpane callbacks easily, by passing them directly to PluginCB().
Pass *tcell.EventMouse to action callbacks for "mouse actions", i.e. to onMousePress, preMouseDrag and so on, similarly to how we pass it to lua functions bound to mouse events.
Now that we can pass extra args directly to PluginCB(), we can remove PluginCBRune() for simplicity.
|
Thanks for this! I tested and it seems to be working fine. |
JoeKar
reviewed
Jun 21, 2025
| @@ -570,7 +568,7 @@ func (h *BufPane) execAction(action BufAction, name string, te *tcell.EventMouse | |||
| case BufMouseAction: | |||
| success = a(h, te) | |||
| } | |||
| success = success && h.PluginCB("on"+name) | |||
| success = success && h.PluginCB("on"+name, te) | |||
There was a problem hiding this comment.
We add this now also for BufKeyAction too, right?
Furthermore...is this optional argument really backward compatible? 🤔
There was a problem hiding this comment.
We add this now also for
BufKeyActiontoo, right?
Yes, but it is nil in that case.
Furthermore...is this optional argument really backward compatible? 🤔
Non-intuitively yes. You can try it. A lua function is free to receive less arguments than we pass to it, or more arguments than we pass to it.
There was a problem hiding this comment.
Ah, ok. Then it is legit. 👍
JoeKar
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
*tcell.EventMouseto action callbacks for "mouse actions", i.e. toonMousePress,preMouseDragand so on, similarly to how we pass it to lua functions bound to mouse events.