fix(ui): fix the default category #1295

abhix4 · 2025-06-11T18:57:23Z

Description

fix this issue:

related issue: #1282

Type of Change

Please delete options that are not relevant.

🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature with breaking changes)
📝 Documentation update
🎨 UI/UX improvement
🔒 Security enhancement
⚡ Performance improvement

Areas Affected

Please check all that apply:

Testing Done

Describe the tests you've done:

Unit tests added/updated
Integration tests added/updated
Manual testing performed
Cross-browser testing (if UI changes)
Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

No sensitive data is exposed
Authentication checks are in place
Input validation is implemented
Rate limiting is considered (if applicable)

Checklist

I have read the CONTRIBUTING document
My code follows the project's style guidelines
I have performed a self-review of my code
I have commented my code, particularly in complex areas
I have updated the documentation
My changes generate no new warnings
I have added tests that prove my fix/feature works
All tests pass locally
Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Add screenshots or recordings here if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

Refactor
- Changed the default selected mail category from "Important" to "All Mail" when viewing mail categories.

coderabbitai · 2025-06-11T18:57:31Z

Walkthrough

The default value for the mail category selection in the Categories component was updated from 'Important' to 'All Mail'. This change affects which category is initially displayed when the component loads or when no category is specified in the query state.

Changes

File(s)	Change Summary
apps/mail/components/mail/mail.tsx	Changed default 'category' query state in Categories from 'Important' to 'All Mail'.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CategoriesComponent

    User->>CategoriesComponent: Load or reset component
    CategoriesComponent->>CategoriesComponent: Initialize query state with default ('All Mail')
    CategoriesComponent-->>User: Display mails in 'All Mail' category

Possibly related PRs

All Mail as Default #1282: Also changes the default value of the category query state from 'Important' to 'All Mail' in the same component.
feat: update categories logic #596: Modifies default category logic in mail.tsx, previously setting it to 'Primary'.
fix: show primary emails #582: Adds the "All Mail" category and updates category filters in the same component.

Poem

In the warren of mail, a shift so small,
From "Important" we hop to "All Mail" for all.
Now every new letter, both big and slight,
Greets the bunny with inbox delight.
🐇📬 Hooray for the change, let’s read through the night!

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

apps/mail/components/mail/mail.tsx (1)
939-941: Avoid default-value duplication – extract a constant

'All Mail' is now hard-coded as the default in two separate hooks (Categories and CategorySelect).
If a future change alters the default again it’s easy to miss one site and create divergent behaviour.

Consider lifting the string into a shared constant, e.g.
export const DEFAULT_CATEGORY = 'All Mail';
and reference it from every useQueryState('category', { defaultValue: DEFAULT_CATEGORY }) call.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 011fd52 and 0daebb5.

📒 Files selected for processing (1)

apps/mail/components/mail/mail.tsx (1 hunks)

apps/mail/components/mail/mail.tsx

MrgSub · 2025-06-13T22:30:09Z

Merge activity

Jun 13, 10:30 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jun 13, 10:30 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

fix the default category

0daebb5

graphite-app bot assigned abhix4 Jun 11, 2025

coderabbitai bot reviewed Jun 11, 2025

View reviewed changes

apps/mail/components/mail/mail.tsx Show resolved Hide resolved

MrgSub approved these changes Jun 13, 2025

View reviewed changes

MrgSub merged commit cdb0205 into Mail-0:staging Jun 13, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(ui): fix the default category #1295

fix(ui): fix the default category #1295

Uh oh!

abhix4 commented Jun 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

MrgSub commented Jun 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(ui): fix the default category #1295

fix(ui): fix the default category #1295

Uh oh!

Conversation

abhix4 commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

related issue: #1282

Type of Change

Areas Affected

Testing Done

Security Considerations

Checklist

Additional Notes

Screenshots/Recordings

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MrgSub commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

abhix4 commented Jun 11, 2025 •

edited

Loading

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MrgSub commented Jun 13, 2025 •

edited

Loading