Skip to content

feat: Add optional embedding normalization to StaticModel loading #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2025
Merged

feat: Add optional embedding normalization to StaticModel loading #164

merged 1 commit into from
Jan 25, 2025

Conversation

davidberenstein1957
Copy link
Contributor

@davidberenstein1957 davidberenstein1957 commented Jan 25, 2025 •
edited
Loading

I noticed the normalize wasn't added to the class methods so I added it.

stephantul
stephantul approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@stephantul stephantul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@stephantul stephantul merged commit b41c3be into MinishLab:main Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephantul stephantul stephantul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidberenstein1957 @stephantul