Skip to content

feat: Added quantization for from_sentence_transformers #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

feat: Added quantization for from_sentence_transformers #219

merged 3 commits into from
Apr 24, 2025

Conversation

Pringled
Copy link
Member

This PR adds support for quantization and dimensionality reduction to from_sentence_transformers. To reduce code duplication, a private helper method is added (_load_model).

@Pringled Pringled requested a review from stephantul April 23, 2025 15:07
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/hf_utils.py 20.00% 4 Missing ⚠️
model2vec/model.py 40.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/quantization.py 96.55% <100.00%> (+1.81%) ⬆️
model2vec/model.py 94.00% <40.00%> (-0.91%) ⬇️
model2vec/hf_utils.py 75.00% <20.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Pringled and others added 2 commits April 23, 2025 17:09
@Pringled
Updates
23bb90b
@stephantul
feat: remove flag argument (#220)
b613033 
* feat: remove flag argument

* fix typing

* add future anns
@Pringled Pringled merged commit 79900e7 into main Apr 24, 2025
5 of 6 checks passed
@Pringled Pringled deleted the add-quantization-for-from-sentence-transformers branch April 24, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephantul stephantul stephantul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pringled @stephantul