This looks good, thanks for the PR. I can see that you didn't run pre-commit on this. Could you make the necessary changes and then run pre-commit before you commit?

sorry, i never used pre-commit before, i installed it and ran it before the last commit i pushed but it doesn't seem to have done anything?

$ pre-commit
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /home/miro/.cache/pre-commit/patch1747854475-1318277.
check python ast.....................................(no files to check)Skipped
trim trailing whitespace.............................(no files to check)Skipped
fix end of files.....................................(no files to check)Skipped
check for added large files..........................(no files to check)Skipped
check for case conflicts.............................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
pydoclint............................................(no files to check)Skipped
ruff.................................................(no files to check)Skipped
ruff-format..........................................(no files to check)Skipped
mypy.................................................(no files to check)Skipped
[INFO] Restored changes from /home/miro/.cache/pre-commit/patch1747854475-1318277.

not sure what is supposed to happen here

No worries, I can show you. From your output, I see you haven't staged the files, or have already pushed them. You can run make install from the root of the project, this will install and run pre-commit as a hook whenever you run git commit. This should make it block you from committing stuff that doesn't pass the pre-commit checks. Let me know if that works.

i don't think my pycharm install is liking pre-commit...

I can have a look later if that is a blocker for the PR and I'll redo it from scratch without pycharm in the mix

The other requested changes have been pushed

@JarbasAl , I added some more validation and tests, and ran the pre-commit. The tests are failing because of some unrelated transformers issue. Feel free to take a look if you like the changes.

The lates commits are to fix the failing CI

awesome, thanks for wrapping this up!

awesome project and super responsive and helpful devs, what else could anyone ask for :)