The symbolic of static content should use relative path #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbolic of static content should use relative path
Member
|
Looks like it works. Mind signing the contrib agreement https://docs.google.com/spreadsheet/embeddedform?formkey=dFNiOFROLXJBbFBmMkQtb1hNMWhUUnc6MQ please? Thanks! |
Contributor
Author
|
Just signed :) |
Member
|
Sorry, coming back to this, how does it affect the packages (deb, rpm, bsd)? Could you test it under those and make sure it still works please? Thanks! |
manolama
pushed a commit
that referenced
this pull request
Dec 11, 2018
* Update Makefile.am The symbolic of static content should use relative path * Set the abs_srcdir and abs_builddir in runtime instead of compiling time Signed-off-by: Chris Larsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbolic of the html and js are created in compiling time. The current implementation use absolute path. It means that the compiled binary could only place in the same absolute path with it in the compile machine. It is not convince for use and deploy. So I change the symbolic of static content form absolute path into relative path