POSIX: fix mktime on 32-bit platforms with large time_t #21554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IV is a 32-bit type, but time_t is bigger, then it is possible for mktime() to return values outside the 32-bit range (> 0x7fff_ffff after 2038-01-19). In that case, fall back to NV (i.e. floating point). A double-precision floating point number provides more than 52 bits of precision, which should be plenty. Fixes Perl#21551.
Leont
approved these changes
Oct 10, 2023
khwilliamson
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If IV is a 32-bit type, but time_t is bigger, then it is possible for mktime() to return values outside the 32-bit range (> 0x7fff_ffff after 2038-01-19). In that case, fall back to NV (i.e. floating point). A double-precision floating point number provides more than 52 bits of precision, which should be plenty.
Fixes #21551.