-
Notifications
You must be signed in to change notification settings - Fork 877
Fixes for Python 3.14 and fixes for deprecations #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix codecs deprecation - Fix issue with unclosed `<![` - Fix issue with unclosed HTML tag `<foo` Fixes Python-Markdown#1537
f157522
to
a823912
Compare
Something in this project's MkDocs setup is choking on an inline code
|
@waylan This is ready for input. I realize these are hacky fixes, but this identifies what the issues are and "possible" ways to fix them. I am open to better approaches if anyone has better approaches, but if we want to have backwards compatibility, this is at least an approach that could be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this looks good. I understand your concern about the general hackiness of the changes, but much of the code for the HTML parser is so I'm not too worried about it.
I'm thinking perhaps we should add a Python 3.14 set of tests to CI. I realize the backport will eventually make its way to all of the Python versions we support, but it would be good to have active tests passing before we merge. We don't need to officially list 3.14 as supported in the project metadata yet (unless it refuses to install), but just the tests. |
Yep, I was planning to do this, just hadn't done it yet. I'll add it to this review. |
It looks like CI is pulling Python 3.14b3 and it is passing, so this verifies the claim that 3.14 has parity with older versions. |
This is still in |
Nope, just wanted input first on whether this was our desired direction. I've moved it to normal review status now. |
<![
<foo
Fixes #1537