Skip to content

Unpin numpy version in macos CI #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Unpin numpy version in macos CI #5345

wants to merge 3 commits into from

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Feb 26, 2025

Proposed changes

Now that numpy2 is supported, ensure we test it

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

None. Need to verify success in mac CI.

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor Author

prckent commented Feb 27, 2025

Interestingly ntest_nexus_structure fails. We need to do something about the error verbosity:

734/1011 Test #1860: ntest_nexus_structure .............................................................................***Failed    0.88 sec
Test name     : structure
Test sublabel : test_min_image_distances
Test exception: "AssertionError: "
Test backtrace:
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 478, in run
    self.operation()
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 870, in structure
    nunit('min_image_distances')
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 349, in nunit
    run_external_unit_test(test_name,unit_test)
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 388, in run_external_unit_test
    unit_test()
  File "/Users/runner/work/qmcpack/qmcpack/nexus/tests/unit/test_structure.py", line 1306, in test_min_image_distances
    assert(set(nti)==set(nti_ref))
           ^^^^^^^^^^^^^^^^^^^^^^

Test status: fail

@prckent
Copy link
Contributor Author

prckent commented Feb 27, 2025

SInce 2.2.3 failed, trying 2.2.2 since that is what is in the nightlies.

@prckent
Copy link
Contributor Author

prckent commented Mar 2, 2025

Update: Not yet successful in reproducing. mac + close approximation to versions in CI installed via brew gave a passing test.

@prckent
Copy link
Contributor Author

prckent commented Apr 3, 2025 •
edited
Loading

Tried rerunning. Still broken. There is clearly a mac specific difference to solve

  735/1011 Test #1882: ntest_nexus_structure .............................................................................***Failed    0.82 sec
Test name     : structure
Test sublabel : test_min_image_distances
Test exception: "AssertionError: "
Test backtrace:
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 478, in run
    self.operation()
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 870, in structure
    nunit('min_image_distances')
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 349, in nunit
    run_external_unit_test(test_name,unit_test)
  File "/Users/runner/work/qmcpack/qmcpack/nexus/bin/nxs-test", line 388, in run_external_unit_test
    unit_test()
  File "/Users/runner/work/qmcpack/qmcpack/nexus/tests/unit/test_structure.py", line 1306, in test_min_image_distances
    assert(set(nti)==set(nti_ref))
           ^^^^^^^^^^^^^^^^^^^^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prckent