Skip to content

[WIP] More templates for the classes derived from SPOSetT<T> #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ylee88
Copy link
Contributor

@ylee88 ylee88 commented Mar 4, 2025

Proposed changes

Introducing templates for the classes derived from SPOSetT<T>. This is the following change towards a unified build for real, complex, and mixed-precision, starting from #5306.

What type(s) of changes does this code introduce?

  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes/No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Mar 10, 2025

Could you make a new PR by cherry-picking ConstantSPOSet, CompositeSPOSet and DummySPOSetWithMW changes. DummySPOSetWithoutMW was removed earlier. Basically leaving out RotatedSPO.

@ylee88
Copy link
Contributor Author

ylee88 commented Mar 11, 2025

@ye-luo I still see DummySPOSetWithoutMW in the develop branch:

class DummySPOSetWithoutMW : public SPOSet

Is there a pending PR removing that?

@ylee88
Copy link
Contributor Author

ylee88 commented Mar 11, 2025

A subset of this PR superseded in #5373.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants