JSONC highlighting & Upgrade VuePress #1091
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
* feat(CONTRIBUTING.md): remove extra emojis * feat(README.md): remove extra emoji
|
所以这 PR 什么时候合呢? 等 VuePress 2 的正式版本发布吗? |
|
插句题外话，vuepress有好多炫酷的主题，打不打算换个呢？ |
这个最好得看易姐同不同意😂 |
|
@wuziqian211 确实 |
|
@SessionHu 我不懂 vuepress，这块都是易姐弄的，你要不去群里 @ShakaiAneE 看看 |
|
@SessionHu 我很早以前就看到了，但我不敢merge，炸了我可不会修 |
wuziqian211
approved these changes
May 8, 2025
|
这个 PR 可以合并了吗？😂 |
|
要么问易姐, 要么等 VuePress 2 正式版发布 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to support JSONC highlighting in VuePress and upgrades VuePress to the latest version.
The NodeJS version is also upgraded to 20.
Workflows in this PR do not use
secrets.ACCESS_TOKENand branchgh_pagesany more.Pages are deploying to GitHub Pages using custom workflows now.
You may need to go to this page and set
Build and deployment -> SourcetoGitHub Actions.At the same time, it fixes some broken links and wrong code block languages.
You can also see these contributors at the bottom of every pages.
The build failed problem is also fixed in this PR.
See #1045 to learn more about JSONC support.
Demo: https://sessionhu.github.io/bilibili-API-collect/
Known issue: Runningyarn buildmay sometimes result in OOM if running environment available memory less than 8GiB.ps: This PR makes the changes in same files as #1088. Merging either will cause conflicts with the other.