Skip to content

Support automatic REST route registration and invocation for custom @Mapping methods in Triple stub service implementation classes. #15370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 3.3
Choose a base branch
from
Open

Support automatic REST route registration and invocation for custom @Mapping methods in Triple stub service implementation classes. #15370

wants to merge 3 commits into from

Conversation

heliang666s
Copy link
Contributor

What is the purpose of the change?

Support automatic REST route registration and invocation for custom @mapping methods in Triple stub service implementation classes.
#15366

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

heliang added 2 commits May 12, 2025 12:29
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (d6b11cf) to head (96c126b).

Files with missing lines Patch % Lines
...dubbo/rpc/stub/ReflectionMappingMethodHandler.java 79.16% 5 Missing ⚠️
...ri/rest/mapping/DefaultRequestMappingRegistry.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15370      +/-   ##
============================================
+ Coverage     60.73%   60.74%   +0.01%     
- Complexity    10920    10927       +7     
============================================
  Files          1886     1887       +1     
  Lines         86162    86188      +26     
  Branches      12913    12915       +2     
============================================
+ Hits          52328    52353      +25     
+ Misses        28374    28371       -3     
- Partials       5460     5464       +4
Flag Coverage Δ
integration-tests 33.15% <6.66%> (+0.03%) ⬆️
samples-tests 29.32% <6.66%> (-0.04%) ⬇️
unit-tests 58.86% <73.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oxsean
Copy link
Contributor

oxsean commented May 15, 2025

I don’t think we need to support this feature. Since the service is defined by proto, we should focus only on the methods exported by the proto. The reason Java reflection supports this is to make it easier for Spring MVC users to migrate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heliang666s @codecov-commenter @oxsean @songxiaosheng