Dubbo MCP Integration #15406

Stellar1999 · 2025-05-20T12:16:06Z

What is the purpose of the change?

Ref: #15332

Checklist

Make sure there is a GitHub_issue field for the change.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

codecov-commenter · 2025-05-20T14:05:47Z

Codecov Report

Attention: Patch coverage is 42.05357% with 649 lines in your changes missing coverage. Please review.

Project coverage is 60.77%. Comparing base (2af3a91) to head (f5a2894).
Report is 8 commits behind head on 3.3.

Files with missing lines	Patch %	Lines
...va/org/apache/dubbo/mcp/core/McpServiceFilter.java	12.13%	151 Missing and 1 partial ⚠️
...ache/dubbo/mcp/tool/DubboOpenApiToolConverter.java	30.09%	120 Missing and 24 partials ⚠️
...pache/dubbo/mcp/tool/DubboServiceToolRegistry.java	57.61%	71 Missing and 18 partials ⚠️
...ava/org/apache/dubbo/mcp/util/TypeSchemaUtils.java	51.38%	77 Missing and 11 partials ⚠️
...e/dubbo/mcp/core/McpApplicationDeployListener.java	30.48%	54 Missing and 3 partials ⚠️
...bo/mcp/transport/DubboMcpSseTransportProvider.java	61.53%	30 Missing ⚠️
...pache/dubbo/mcp/core/McpServiceExportListener.java	48.14%	25 Missing and 3 partials ⚠️
...g/apache/dubbo/mcp/tool/DubboMcpGenericCaller.java	47.16%	25 Missing and 3 partials ⚠️
...java/org/apache/dubbo/config/nested/McpConfig.java	0.00%	17 Missing ⚠️
...a/org/apache/dubbo/mcp/core/McpSseServiceImpl.java	0.00%	12 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff              @@
##                3.3   #15406      +/-   ##
============================================
+ Coverage     60.74%   60.77%   +0.02%     
- Complexity    10934    11444     +510     
============================================
  Files          1887     1898      +11     
  Lines         86242    87386    +1144     
  Branches      12927    13134     +207     
============================================
+ Hits          52391    53105     +714     
- Misses        28377    28777     +400     
- Partials       5474     5504      +30

Flag	Coverage Δ
integration-tests	`?`
integration-tests-java17	`32.69% <1.69%> (?)`
integration-tests-java8	`32.71% <0.35%> (?)`
samples-tests	`?`
samples-tests-java17	`31.08% <1.25%> (?)`
samples-tests-java8	`28.99% <0.26%> (?)`
unit-tests	`58.71% <41.60%> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…d optimized the port selection logic when configurations are not provided.

Add errorCode. Add unitTest

Stellar1999 · 2025-05-24T05:00:30Z

PTAL @AlbumenJ @CrazyHZM

…g and refactor package structure

wcy666103

There are many Chinese comments in the change commit.

Stellar1999 · 2025-05-26T12:21:02Z

There are many Chinese comments in the change commit.

Done.Translation completed.

SpursJiang · 2025-05-26T15:03:27Z

Dear Dubbo team:
Once a Dubbo service interface is registered as an MCP (Mesh Control Plane) tool, is its metadata stored exclusively in local memory? Furthermore, are there any plans to register MCP tools with the MCP register in Nacos version 3?
Is the Streamable HTTP protocol supported?

zrlw · 2025-05-27T01:46:43Z

There are many Chinese comments in the change commit.

Done.Translation completed.

no, there are still chinese comments. i.e. McpConstant.java

Stellar1999 · 2025-05-27T02:47:05Z

There are many Chinese comments in the change commit.

Done.Translation completed.

no, there are still chinese comments. i.e. McpConstant.java

You're right. done.

Stellar1999 · 2025-05-27T02:50:01Z

Dear Dubbo team: Once a Dubbo service interface is registered as an MCP (Mesh Control Plane) tool, is its metadata stored exclusively in local memory? Furthermore, are there any plans to register MCP tools with the MCP register in Nacos version 3? Is the Streamable HTTP protocol supported?

Is its metadata stored exclusively in local memory? Yes.
Furthermore, are there any plans to register MCP tools with the MCP registry in Nacos version 3? Under consideration.
Is the Streamable HTTP protocol supported? No, but I believe we will support it in the future.Now just sse.

dubbo-plugin/dubbo-mcp/pom.xml

...o-plugin/dubbo-mcp/src/main/java/org/apache/dubbo/mcp/core/McpApplicationDeployListener.java

dubbo-plugin/dubbo-mcp/src/main/java/org/apache/dubbo/mcp/core/McpServiceFilter.java

dubbo-plugin/dubbo-mcp/src/main/java/org/apache/dubbo/mcp/tool/DubboMcpGenericCaller.java

Optimize some code.

SpursJiang · 2025-05-27T08:29:49Z

Dear Dubbo team: Once a Dubbo service interface is registered as an MCP (Mesh Control Plane) tool, is its metadata stored exclusively in local memory? Furthermore, are there any plans to register MCP tools with the MCP register in Nacos version 3? Is the Streamable HTTP protocol supported?

Is its metadata stored exclusively in local memory? Yes.

Furthermore, are there any plans to register MCP tools with the MCP registry in Nacos version 3? Under consideration.

Is the Streamable HTTP protocol supported? No, but I believe we will support it in the future.Now just sse.

OK👍

…exposure of MCP services.

…tion parsing

…/mcp_plugin

Stellar1999 force-pushed the feature/mcp_plugin branch 4 times, most recently from 4b00a76 to 4739e28 Compare May 20, 2025 13:49

Stellar1999 force-pushed the feature/mcp_plugin branch from 4739e28 to c1ad13b Compare May 20, 2025 14:40

move dubbo-mcp-sdk to dubbo plugin

1eb59ac

Stellar1999 force-pushed the feature/mcp_plugin branch from c1ad13b to 1eb59ac Compare May 20, 2025 14:49

Stellar1999 added 2 commits May 21, 2025 18:43

Added configuration options for MCP, switches, and SSE path ports, an…

6040178

…d optimized the port selection logic when configurations are not provided.

Edit error log,Let it print error code

14b00ff

Stellar1999 force-pushed the feature/mcp_plugin branch 5 times, most recently from 763676c to 1913eb8 Compare May 24, 2025 02:47

Edit sessions as ExpiringCache.

5cd8426

Add errorCode. Add unitTest

Stellar1999 force-pushed the feature/mcp_plugin branch from 1913eb8 to 5cd8426 Compare May 24, 2025 03:05

Stellar1999 marked this pull request as ready for review May 24, 2025 04:50

heliang666s added 2 commits May 26, 2025 09:41

support @DubboService annotation for service control, optimize loggin…

ad18b6d

…g and refactor package structure

code format

dc4cac6

wcy666103 suggested changes May 26, 2025

View reviewed changes

Stellar1999 force-pushed the feature/mcp_plugin branch from 18e1a2c to f72f378 Compare May 26, 2025 08:45

Stellar1999 force-pushed the feature/mcp_plugin branch from f72f378 to 7057efb Compare May 27, 2025 02:46

AlbumenJ requested changes May 27, 2025

View reviewed changes

Stellar1999 force-pushed the feature/mcp_plugin branch from a198140 to a9e7913 Compare May 27, 2025 03:53

Fix the log format and translate all Chinese comments into English.

b20acfe

Optimize some code.

Stellar1999 force-pushed the feature/mcp_plugin branch from a9e7913 to b20acfe Compare May 27, 2025 07:15

heliang666s and others added 10 commits June 1, 2025 23:35

Add the @mcptool and @McpToolParam annotations to support customized …

d31e66a

…exposure of MCP services.

support dynamic MCP tool registration and correct URL-based configura…

5db5ff7

…tion parsing

Merge branch '3.3' into feature/mcp_plugin

d9c70ea

fix:log format

cd83d35

add attribute = false

789c0ff

Merge remote-tracking branch 'origin/feature/mcp_plugin' into feature…

b7cc4d6

…/mcp_plugin

code format

d07cfa4

fix move file path

6f02019

add unit tests

11ed8e1

fix unit tests

f5a2894

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dubbo MCP Integration #15406

Dubbo MCP Integration #15406

Stellar1999 commented May 20, 2025

Uh oh!

codecov-commenter commented May 20, 2025 •

edited

Loading

Uh oh!

Stellar1999 commented May 24, 2025

Uh oh!

wcy666103 left a comment

Uh oh!

Stellar1999 commented May 26, 2025

Uh oh!

SpursJiang commented May 26, 2025

Uh oh!

zrlw commented May 27, 2025

Uh oh!

Stellar1999 commented May 27, 2025

Uh oh!

Stellar1999 commented May 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SpursJiang commented May 27, 2025

Uh oh!

Uh oh!

Dubbo MCP Integration #15406

Are you sure you want to change the base?

Dubbo MCP Integration #15406

Conversation

Stellar1999 commented May 20, 2025

What is the purpose of the change?

Checklist

Uh oh!

codecov-commenter commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Stellar1999 commented May 24, 2025

Uh oh!

wcy666103 left a comment

Choose a reason for hiding this comment

Uh oh!

Stellar1999 commented May 26, 2025

Uh oh!

SpursJiang commented May 26, 2025

Uh oh!

zrlw commented May 27, 2025

Uh oh!

Stellar1999 commented May 27, 2025

Uh oh!

Stellar1999 commented May 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SpursJiang commented May 27, 2025

Uh oh!

Uh oh!

codecov-commenter commented May 20, 2025 •

edited

Loading