Skip to content

fix: Fix some bugs about proto #15412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from
Open

fix: Fix some bugs about proto #15412

wants to merge 1 commit into from

Conversation

paxxie2
Copy link

@paxxie2 paxxie2 commented May 27, 2025

What is the purpose of the change?

fix bug: #15357 #15358 #15361 #15291

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 18 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (c778473) to head (42bd630).
Report is 53 commits behind head on 3.3.

Files with missing lines Patch % Lines
...est/support/basic/BasicRequestMappingResolver.java 63.15% 2 Missing and 5 partials ⚠️
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 87.23% 6 Missing ⚠️
...g/apache/dubbo/rpc/model/StubMethodDescriptor.java 0.00% 2 Missing ⚠️
...ri/rest/mapping/DefaultRequestMappingRegistry.java 71.42% 1 Missing and 1 partial ⚠️
...he/dubbo/rpc/model/ReflectionMethodDescriptor.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.3   #15412      +/-   ##
============================================
- Coverage     60.77%   60.74%   -0.03%     
- Complexity    10920    10943      +23     
============================================
  Files          1886     1887       +1     
  Lines         86122    86265     +143     
  Branches      12902    12931      +29     
============================================
+ Hits          52337    52403      +66     
- Misses        28331    28387      +56     
- Partials       5454     5475      +21
Flag Coverage Δ
integration-tests 33.21% <28.39%> (+0.01%) ⬆️
samples-tests 29.32% <7.40%> (-0.03%) ⬇️
unit-tests 58.89% <77.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paxxie2 @codecov-commenter