Resolves #557 - Use @container style as custom media query #558
Conversation
|
|
|
@argyleink it is not ready yet, but i would like a feedback if i'm on the right track |
AlessioCoser
changed the title
|
I kinda followed the animation file more or less, and generated accordingly the required @argyleink this should be a working version. Tell me if you see something wrong |
|
giving this a look now, thanks for the patience! |
There was a problem hiding this comment.
found one minor syntax nit, no biggie
the last task afaict, is to include these new props in the JS object output too, for the css-in-js users. this just means opening up build/to-object.js and adding the container values to the lists.
then update tests: expected as this PR is adding a lot of new props. you can run the tests locally to see the new total, then update that value in the test, and then this PR should be good to go 👍🏻
| @@ -2,6 +2,7 @@ import Animations from './props.animations.js' | |||
| import Sizes from './props.sizes.js' | |||
| import Colors from './props.colors.js' | |||
| import ColorsHSL from './props.colors-hsl.js' | |||
| import Container from "./props.container.js"; | |||
There was a problem hiding this comment.
| import Container from "./props.container.js"; | |
| import Container from './props.container.js' |
match style of others
No description provided.