-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Adjust tinyUSD patch to enable compilation of library #6071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Michał Pełka <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patching is notoriously tricky, please respect the original patch convention to avoid breaking for other users
Also please ensure patchfile line endings set to LF
not CRLF
before committing
diff -rupN -x .git autoclone/tinyusdz_repo-src/src/external/stb_image_resize2.h tinyusdz_repo_patch/src/external/stb_image_resize2.h | ||
--- autoclone/tinyusdz_repo-src/src/external/stb_image_resize2.h 2024-07-09 21:29:48.556969900 -0700 | ||
+++ tinyusdz_repo_patch/src/external/stb_image_resize2.h 2024-07-09 23:03:47.379316700 -0700 | ||
@@ -2404,6 +2404,38 @@ static stbir__inline stbir_uint8 stbir__ | ||
diff --git a/src/external/stb_image_resize2.h b/src/external/stb_image_resize2.h | ||
index 1cd379a7..c2f767a3 100644 | ||
--- a/src/external/stb_image_resize2.h | ||
+++ b/src/external/stb_image_resize2.h | ||
@@ -2404,6 +2404,38 @@ static stbir__inline stbir_uint8 stbir__linear_to_srgb_uchar(float in) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete these changes, it is likely to break the patch for other users
@@ -40,3 +41,16 @@ diff -rupN -x .git autoclone/tinyusdz_repo-src/src/external/stb_image_resize2.h | |||
#elif defined(STBIR_NEON) && defined(_MSC_VER) && defined(_M_ARM64) && !defined(__clang__) // 64-bit ARM on MSVC (not clang) | |||
|
|||
static stbir__inline void stbir__half_to_float_SIMD(float * output, stbir__FP16 const * input) | |||
diff --git a/src/lz4-compression.cc b/src/lz4-compression.cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to
diff -rupN -x .git autoclone/tinyusdz_repo-src/src/lz4-compression.cc tinyusdz_repo_patch/src/lz4-compression.cc
--- a/src/lz4-compression.cc | ||
+++ b/src/lz4-compression.cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to
--- autoclone/tinyusdz_repo-src/src/lz4-compression.cc 2024-07-09 21:29:48.556969900 -0700
+++ tinyusdz_repo_patch/src/lz4-compression.cc 2024-07-09 23:03:47.379316700 -0700
There was signing comparison warning that stopped build