Don't retry securitytrails ping API on HTTP 429 #2490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
securitytrails.com's ping API returns 429 if you've exceeded the quota for the API key. This delays the setup phase by 90 seconds. This fix introduces a ping_retry_on_http_429 flag which can be set to False to avoid this behaviour. The flag is set to False on the securitytrails module.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2490 +/- ##
=====================================
- Coverage 93% 93% -0%
=====================================
Files 400 398 -2
Lines 33093 33063 -30
=====================================
- Hits 30613 30584 -29
+ Misses 2480 2479 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR. This is a good default to have, so I went ahead and updated all the modules to use it. |
TheTechromancer
approved these changes
Jun 6, 2025
ausmaster
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
securitytrails.com's ping API returns 429 if you've exceeded the quota for the API key. This delays the setup phase by 90 seconds. This fix introduces a ping_retry_on_http_429 flag which can be set to False to avoid this behaviour. The flag is set to False on the securitytrails module.