Improving the TipTap image extension to support images having links #15468
+176
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds the ability for users to add links to images in Tiptap editors. Previously, images could not be clickable links, limiting content authoring capabilities.
Changes include:
hrefattribute to the image node, allowing images to store link URLs<a>tags withtarget="_blank"andrel="noopener noreferrer"for securityTechnical implementation:
📌 Related Issues
Testing
https://example.com)Automated Testing:
Run the image extension test suite:
npm test -- decidim-core/app/packs/src/decidim/editor/test/extensions/image.test.jsNew test cases cover:
Accessibility Testing:
aria-hiddenwarnings appear in the console when opening/closing the dialog📷 Screenshots
Image dialog with new link field:

Linked image in editor:

HTML output: