Skip to content

Add a CaptureQueue class #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SebMichaud
Copy link

Added a CaptureQueue class following issue 575 and its last message from @kayoub5

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 68.70%. Comparing base (beeb097) to head (11748ab).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
SharpPcap/LibPcap/CaptureQueue.cs 0.00% 27 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (beeb097) and HEAD (11748ab). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (beeb097) HEAD (11748ab)
7 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #580       +/-   ##
===========================================
- Coverage   81.16%   68.70%   -12.46%     
===========================================
  Files          51       52        +1     
  Lines        2814     2841       +27     
  Branches      328      327        -1     
===========================================
- Hits         2284     1952      -332     
- Misses        417      782      +365     
+ Partials      113      107        -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SebMichaud
Copy link
Author

SebMichaud commented May 6, 2025

Hi @kayoub5 can you see my commit from today ?
I tried to add the suggested features.
Anyway, it doesn't work and I don't know why.
I need to cast the BlockingCollection to a simple List in the Flush method, because it's way more convenient for the final user.
Could you review it and test it on your side ?
Thanks

@chmorgan
Copy link
Collaborator

@SebMichaud can you add a test for the CaptureQueue in the Tests folder that uses the class in the way that your labview side is using it? That would let us exercise the api and make it easier for others to help debug and resolve implementation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants