fix PopupMenuButton unmounted exception when updating position #166412
Conversation
github-actions
bot
added
framework
| await tester.tap(find.byKey(buttonKey)); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| // TODO(sstasi95): here we should trigger a layout change to test the fix |
There was a problem hiding this comment.
You can try pumping an unrelated widget with the tester (I.e. a SizedBox), after the button is tapped, to trigger the unmounting of the popup menu.
There was a problem hiding this comment.
I've tried but it's not enough, we should also update the layout after the popup menu is unmounted but when is still visible (during the pop animation), as you can see in this screen recording. This way the _positionBuilder method will be called on an unmounted popup menu.
Co-authored-by: Navaron Bracke <[email protected]>
|
Hey @sstasi95 it looks like this never entered our review queue since this is a draft. Would you like to move forward with this change? |
|
Hi @Piinks, sure. I left it as a draft because I wasn't able to write a test for it, I'll mark it ready for review now |
This PR fixes an exception thrown when trying to update an unmounted PopupMenuButton's position, which can happen when a layout change is triggered during PopupMenuButton's pop animation (see issue's attached video).
A workaround is to set
popUpAnimationStyle: AnimationStyle.noAnimation.This PR fixes it by returning the last known position if the button is unmounted.
Exception thrown:
FlutterError (This widget has been unmounted, so the State no longer has a context (and should be considered defunct). Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active.)Code that causes the exception:
final PopupMenuThemeData popupMenuTheme = PopupMenuTheme.of(context);Fixes #163477
Tested both on stable (3.29.2) and master (a0b1b32)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.