[Android 16] Updating Engine to Use Java 21 #167776
Draft
+12
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the engine to use Java 21.
Some Java 21 changes that affect our tests:
mock
to fake theByteBuffer
class (mockito issue here). I replaced the usage with a captor instead.AccessiblityBridgeTest.java
, which uses chinese characters.To reproduce the error in AccessiblityBridgeTest.java locally, follow these steps:
et build -c android_debug_unopt
gclient sync -D
from rootengine/src/flutter/third_party/java/openjdk/openjdk.cipd.yaml
to make sure JDK 21 has been properly generated. If you see "OpenJDK 21," it has been properly generated.engine/src/flutter
and runtesting/run_tests.py --android-variant=android_debug_unopt --type=java --java-filter=io.flutter.view.AccessibilityBridgeTest
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.