[flutter_tools] Add --no-codesign support for macOS build #169034
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tool
vashworth
reviewed
May 21, 2025
| @@ -192,6 +193,10 @@ Future<void> buildMacOS({ | |||
| } | |||
| } | |||
|
|
|||
| if (!codesign) { | |||
| globals.printStatus('Codesigning disabled with --no-codesign.'); | |||
| } | |||
There was a problem hiding this comment.
I would move this into the command and make the message more like the iOS version:
flutter/packages/flutter_tools/lib/src/commands/build_ios.dart
Lines 741 to 746 in 61fe9b6
knopp
force-pushed
the
macos_no_codesign
branch
3 times, most recently
from
11717f1 to
9d4c2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike iOS, the macOS build currently does not support
--no-codesignoption to skip signing of application bundle. Having this option is useful for situation where the code-signing step is happens separately after the bundle is built (i.e. on CI).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.