Skip to content

licenses_cpp: initial commit #169105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Jun 10, 2025
Merged

licenses_cpp: initial commit #169105

merged 59 commits into from
Jun 10, 2025
+3,882 −8

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented May 19, 2025 •
edited
Loading

Initial commit for the c++ license checker.

This lays the foundation for all the technical challenges. The logic isn't 100% what we want yet. This is a facsimile of the operations we want to perform and currently it operates in 30s as opposed to 30m with the old license chcker.

Included in this PR:

  1. Sets up BUILD.gn
    1. Makes RE2 available to the repo.
    2. Sets up the test infrastructure (integration and unit tests).
    3. Sets up the executable.
    4. Sets up VSCode integration
  2. Sets up the CI (macos builds for now)
  3. Sets up logic
    1. Sets up the crawling through the tree.
    2. Sets up flex lexer for comments.
    3. Runs git subprocesses.
    4. Parses command line arguments.
  4. Sets up data practices
    1. Allow/deny lists added.
    2. In memory representation of license catalog added.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label May 19, 2025
gaaclarke added 29 commits June 3, 2025 09:07
@gaaclarke
stubbed in executable
dabe216
@gaaclarke
started finding the files
58df37a
@gaaclarke
split out license checker
2be219e
@gaaclarke
removed pragma
ce8833d
@gaaclarke
format
e711f9e
@gaaclarke
added test runner
686fcf9
@gaaclarke
started doing 1 regex check
00c66f6
@gaaclarke
updated regex
e85630c
@gaaclarke
added filter class
da6ec49
@gaaclarke
started using include filter
5c42591
@gaaclarke
set verbosity of the checker
383625a
@gaaclarke
made sure to filter before opening the file
bf01ae0
@gaaclarke
split out mmapfile
cb343ac
@gaaclarke
format
b41287f
@gaaclarke
fs
0c4edc4
@gaaclarke
started looking for license files
10e381a
@gaaclarke
added exclude filter
b5418f3
@gaaclarke
cleanup
4317e38
@gaaclarke
added flex lexer
5541f71
@gaaclarke
added comments unit test
aafb13d
@gaaclarke
got multiline working
4914b23
@gaaclarke
added multiline cpp
bf7e871
@gaaclarke
cleanup
aee1766
@gaaclarke
moved to using buffer like a buffer
f00e444
@gaaclarke
started consuming output from lexer
5bfac16
@gaaclarke
typo
ff1787b
@gaaclarke
format
d343a48
@gaaclarke
added comments and stopped looking for copyright headers in third_party
b78cc6f
@gaaclarke
got temp directories made for tests
3661509
matanlurey
matanlurey approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with checking this in and iterating.

@gaaclarke gaaclarke marked this pull request as ready for review June 4, 2025 21:39
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 4, 2025

autosubmit label was removed for flutter/flutter/169105, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 6, 2025

autosubmit label was removed for flutter/flutter/169105, because - The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 6, 2025

autosubmit label was removed for flutter/flutter/169105, because - The status or check suite Windows windows_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 6, 2025

autosubmit label was removed for flutter/flutter/169105, because - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 8, 2025

autosubmit label was removed for flutter/flutter/169105, because - The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke
Copy link
Member Author

rerunning:

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 10, 2025
Merged via the queue into flutter:master with commit 386f767 Jun 10, 2025
182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2025
@engine-flutter-autoroll
386f767f3 licenses_cpp: initial commit (flutter/flutter#169105)
e48d1c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @matanlurey