add run_gradle_lock_files_check.dart for new PR's that modify gradle files #169245
+526
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2moon
changed the title
ash2moon
force-pushed
the
feat/gradle_lock_files#test_changes
branch
from
c6cf8ad to
d1344bd
Compare
9 tasks
…ges' into feat/gradle_lock_files#test_changes
…ges' into feat/gradle_lock_files#test_changes
|
converting to a draft because I think it is still in progress. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
requested changes
Jun 4, 2025
matanlurey
reviewed
Jun 4, 2025
matanlurey
reviewed
Jun 4, 2025
…/gradle_lock_files#test_changes
…files#test_changes
…sk instead of creating a new task
…ges' into feat/gradle_lock_files#test_changes
…sk instead of creating a new task
…sk instead of creating a new task
…sk instead of creating a new task
matanlurey
reviewed
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit checks if there have been any changes to the gradle files and if gradle lock files need updating. If so, it will alert then PR owner to update their PR with the new gradle lock file.s
Fixes #163228
Example test run: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712427303492230593/+/u/run_gradle_java8_compile_test/stdout?format=raw
This was added as an existing test under Linux gradle_java8_compile_test because benchmarking results showed on average about 3min 30s to run on my local M2 Mac. SInce it is not > 10min to run, placing it inside an existing test case was ideal.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.