Use baseUri of WebAssetServer for reload_scripts.json #169267

dumazy · 2025-05-22T11:04:30Z

This allows embedded Flutter Web apps, hosted on a different URL than the host app, to hot reload the correct files.

This fixes issues mentioned in:

It specifically allows you to use hot reload when debugging an embedded Flutter Web app, running in the spawned Chrome browser via the -d chrome flag, as mentioned in dart-lang/sdk#60776 (comment)

Result

This would result in the following reload_scripts.json for an embedded Flutter web app, running on localhost:8081:

[{
    "src": "http://localhost:8081/packages/web_hot_reload/main.dart.lib.js",
    "libraries": ["package:web_hot_reload/main.dart"]
}]

Normal Flutter Web apps

This also adds the baseUri to the maps for normal Flutter Web apps, for example:

[{
    "src": "http://localhost:54609/packages/web_hot_reload/main.dart.lib.js",
    "libraries": ["package:web_hot_reload/main.dart"]
}]

instead of the previous:

[{
    "src": "packages/web_hot_reload/main.dart.lib.js",
    "libraries": ["package:web_hot_reload/main.dart"]
}]

While both actually work, I'm not sure if there might be cases in which this would have another side effect.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This allows embedded Flutter Web apps, hosted on a different URL than the host app, to reload the correct files

flutter-dashboard · 2025-05-22T11:04:33Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

biggs0125 · 2025-05-22T22:04:10Z

Thanks for digging into this! Seems like a reasonable change to me but hopefully some folks who have worked in these file serving libraries a bit more can verify.

srujzs

Thanks for looking into this!

This should be fine in the non-embedded case. This only ever gets use in the module loader when we load script elements.

srujzs · 2025-05-23T16:26:54Z

@dumazy I'm guessing you don't have write access, so I'll apply the autosubmit label so that it merges when the tree's green. Thanks again!

auto-submit · 2025-05-23T16:27:10Z

autosubmit label was removed for flutter/flutter/169267, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

srujzs · 2025-05-23T16:28:02Z

@natebiggs Looks like we need one more approval, mind approving?

…ter/flutter#169267)

flutter/flutter@85564cb...60050a0 2025-05-24 [email protected] Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter/flutter#169414) 2025-05-24 [email protected] Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter/flutter#169406) 2025-05-24 [email protected] Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter/flutter#169308) 2025-05-24 [email protected] Baseline-align CupertinoTextField placeholder (flutter/flutter#166952) 2025-05-24 [email protected] Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter/flutter#169403) 2025-05-24 [email protected] Start removing Observatory support and references (flutter/flutter#169216) 2025-05-23 [email protected] Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter/flutter#169393) 2025-05-23 [email protected] Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter/flutter#169379) 2025-05-23 [email protected] [Engine] Fast blurring algorithm for RSuperellipse (flutter/flutter#169187) 2025-05-23 [email protected] Add a page describing best CI practices for `flutter`-org repos (flutter/flutter#169364) 2025-05-23 [email protected] Revert "Mark web_tool_tests_1_2 as bringup." (flutter/flutter#169361) 2025-05-23 [email protected] Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter/flutter#169369) 2025-05-23 [email protected] Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter/flutter#169349) 2025-05-23 [email protected] Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter/flutter#169317) 2025-05-23 [email protected] Use baseUri of WebAssetServer for reload_scripts.json (flutter/flutter#169267) 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use pub workspace (#168662)" (flutter/flutter#169357) 2025-05-23 [email protected] Use pub workspace (flutter/flutter#168662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* master: (125 commits) Roll Fuchsia Linux SDK from XtPp9bBW49iDJ0wbA... to -eo2JqnJBauuGSzoW... (flutter#169424) Roll Skia from 91dc88dc70e5 to 443f5257f382 (1 revision) (flutter#169422) Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter#169414) Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter#169406) Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter#169308) Baseline-align CupertinoTextField placeholder (flutter#166952) Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter#169403) Start removing Observatory support and references (flutter#169216) Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter#169393) Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter#169379) [Engine] Fast blurring algorithm for RSuperellipse (flutter#169187) Add a page describing best CI practices for `flutter`-org repos (flutter#169364) Revert "Mark web_tool_tests_1_2 as bringup." (flutter#169361) Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter#169369) Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter#169349) Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter#169317) Use baseUri of WebAssetServer for reload_scripts.json (flutter#169267) Reverts "Use pub workspace (flutter#168662)" (flutter#169357) Use pub workspace (flutter#168662) Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter#169276)" (flutter#169347) ...

…r#9318) flutter/flutter@85564cb...60050a0 2025-05-24 [email protected] Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter/flutter#169414) 2025-05-24 [email protected] Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter/flutter#169406) 2025-05-24 [email protected] Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter/flutter#169308) 2025-05-24 [email protected] Baseline-align CupertinoTextField placeholder (flutter/flutter#166952) 2025-05-24 [email protected] Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter/flutter#169403) 2025-05-24 [email protected] Start removing Observatory support and references (flutter/flutter#169216) 2025-05-23 [email protected] Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter/flutter#169393) 2025-05-23 [email protected] Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter/flutter#169379) 2025-05-23 [email protected] [Engine] Fast blurring algorithm for RSuperellipse (flutter/flutter#169187) 2025-05-23 [email protected] Add a page describing best CI practices for `flutter`-org repos (flutter/flutter#169364) 2025-05-23 [email protected] Revert "Mark web_tool_tests_1_2 as bringup." (flutter/flutter#169361) 2025-05-23 [email protected] Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter/flutter#169369) 2025-05-23 [email protected] Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter/flutter#169349) 2025-05-23 [email protected] Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter/flutter#169317) 2025-05-23 [email protected] Use baseUri of WebAssetServer for reload_scripts.json (flutter/flutter#169267) 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use pub workspace (#168662)" (flutter/flutter#169357) 2025-05-23 [email protected] Use pub workspace (flutter/flutter#168662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Use baseUri of WebAssetServer for reload_scripts.json

e01e6d5

This allows embedded Flutter Web apps, hosted on a different URL than the host app, to reload the correct files

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 22, 2025

Fix doc comments of performReload

9750a7b

biggs0125 requested a review from srujzs May 22, 2025 22:02

srujzs approved these changes May 23, 2025

View reviewed changes

Merge branch 'master' into fix/hot-reload-embedded

ce5a39a

srujzs added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

biggs0125 approved these changes May 23, 2025

View reviewed changes

srujzs added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

auto-submit bot added this pull request to the merge queue May 23, 2025

Merged via the queue into flutter:master with commit 171e272 May 23, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025

engine-flutter-autoroll mentioned this pull request May 24, 2025

Roll Flutter from 85564cbba9e7 to 60050a0b4d56 (17 revisions) flutter/packages#9318

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2025

171e272cf Use baseUri of WebAssetServer for reload_scripts.json (flut…

f3efb33

…ter/flutter#169267)

biggs0125 mentioned this pull request Jun 2, 2025

Hot Reload Not Working on Flutter 3.32.1 with Custom Web Launch Configuration dart-lang/sdk#60837

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use baseUri of WebAssetServer for reload_scripts.json #169267

Use baseUri of WebAssetServer for reload_scripts.json #169267

Uh oh!

dumazy commented May 22, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented May 22, 2025

Uh oh!

biggs0125 commented May 22, 2025

Uh oh!

srujzs left a comment

Uh oh!

srujzs commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

srujzs commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

Use baseUri of WebAssetServer for reload_scripts.json #169267

Use baseUri of WebAssetServer for reload_scripts.json #169267

Uh oh!

Conversation

dumazy commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Result

Normal Flutter Web apps

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 22, 2025

Uh oh!

biggs0125 commented May 22, 2025

Uh oh!

srujzs left a comment

Choose a reason for hiding this comment

Uh oh!

srujzs commented May 23, 2025

Uh oh!

auto-submit bot commented May 23, 2025

Uh oh!

srujzs commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

dumazy commented May 22, 2025 •

edited

Loading