Skip to content

use Material widget for improved ink effects #169368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ayyoub-coder
Copy link
Contributor

@ayyoub-coder ayyoub-coder commented May 23, 2025

fix NavigationIndicator to changes to selectedIndex correctly

issue : #169249

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 23, 2025
@dkwingsmt dkwingsmt self-requested a review June 4, 2025 18:41
@dkwingsmt
Copy link
Contributor

@justinmc @TahaTesser It seems like that you have a bit more context to the target issue. Would you like to take a look at this PR?

@TahaTesser
Copy link
Member

@ayyoub-coder
Thanks for the contribution. Could you please provide more details in the description how this address the issue? It seems like you've linked a closed issue. The issue was fixed by @bleroux PR which reverted a change.

It seems like there are a lot of tests failures as well.

@TahaTesser TahaTesser requested a review from bleroux June 12, 2025 20:41
@bleroux
Copy link
Contributor

bleroux commented Jun 16, 2025

Thanks for your contribution 🙏

Closing this PR as the issue was fixed by the following revert: #169497.

@bleroux bleroux closed this Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants