-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Export FlutterSceneDelegate #170169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export FlutterSceneDelegate #170169
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
CI had a failure that stopped further tests from running. We need to investigate to determine the root cause. SHA at time of execution: 228030a. Possible causes:
A blank commit, or merging to head, will be required to resume running CI for this PR. Error Details:
Stack trace:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that uses this and maybe checks the window
isn't null?
Rough example, here's a macOS one that grabs the app delegate
flutter/dev/integration_tests/flutter_gallery/macos/RunnerTests/RunnerTests.m
Lines 14 to 16 in 631ab17
NSMenu *applicationMenu = ((FlutterAppDelegate *)NSApplication.sharedApplication.delegate).applicationMenu; | |
XCTAssertEqual(applicationMenu.numberOfItems, 11); | |
XCTAssertEqualObjects([applicationMenu itemAtIndex:0].title, @"About Flutter Gallery"); |
Could put it here, even though it's not a platform view test:
- (void)testViewControllerIconLoaded { |
Just subclassing FlutterSceneDelegate in a flutter level test should assert that the symbol is public (it would fail to link when this is wrong). I'm not sure where to put it though. I don't want to put it in the examples directory since creating one isn't an example we want to provide (yet?). |
Done, added it to the |
autosubmit label was removed for flutter/flutter/170169, because - The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/flutter/170169, because - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
rebasing to hopefully remove web_tool_tests although I can't get turning them to bringup landed |
merging master, still running into #170264 |
b272e30
to
e70289f
Compare
I've rebased this PR on what I estimate is the last good commit before a dart roll. |
As i expected, rebasing to before 2eec076 allowed this to pass CI. |
Export FlutterSceneDelegate (flutter#170169)
This allows people to subclass FlutterSceneDelegate. This is necessary for many workflows like capturing launchoptions.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.