Invalidate build target when new output file is added #170253
Merged
+123
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
bkonyi
approved these changes
Jun 9, 2025
| @@ -152,7 +152,7 @@ abstract class Target { | |||
| /// | |||
| /// Returning `true` will cause [build] to be skipped. This is equivalent | |||
| /// to a build that produces no outputs. | |||
| bool canSkip(Environment environment) => false; | |||
| Future<bool> canSkip(Environment environment) async => false; | |||
There was a problem hiding this comment.
Why does this need to be made async?
There was a problem hiding this comment.
I have a big PR coming and I'm trying to break it out into smaller bits. Eventually I want to add this, which requires it to be async:
vashworth
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build targets are re-run when invalidated. This PR changes it so when a new output file is added to the expected output files, the build target will be invalidated and re-run.
This PR also changes
canSkipto an async call.These changes are needed for #166486.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.